Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add * to required billing address form fields on checkout payment details #19394

Merged
merged 5 commits into from
Oct 17, 2024
Merged

fix: add * to required billing address form fields on checkout payment details #19394

merged 5 commits into from
Oct 17, 2024

Conversation

uroslates
Copy link
Contributor

No description provided.

@uroslates uroslates requested a review from a team as a code owner October 14, 2024 10:28
@github-actions github-actions bot marked this pull request as draft October 14, 2024 10:28
@uroslates uroslates marked this pull request as ready for review October 14, 2024 10:50
@cypress Cypress
Copy link

cypress bot commented Oct 14, 2024 •
edited
Loading

spartacus    Run #45373

Run Properties:  status check passed Passed #45373  •  git commit c45a220c6c ℹ️: Merge c02fb289aa97f7ea59998a08759c206773e0d8ca into 35a17518df41253c6f37e48c3aef...
Project spartacus
Run status status check passed Passed #45373
Run duration 04m 07s
Commit git commit c45a220c6c ℹ️: Merge c02fb289aa97f7ea59998a08759c206773e0d8ca into 35a17518df41253c6f37e48c3aef...
Committer Uros Lates
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125

@github-actions github-actions bot marked this pull request as draft October 15, 2024 12:11
Zeyber
Zeyber previously approved these changes Oct 16, 2024
View reviewed changes
@Zeyber
Copy link
Contributor

Zeyber commented Oct 16, 2024

A couple things before merge:

  • I think we should use feat: prefix or better fix: in the commit title so that the changelog is generated correctly when we do a release. We should move or drop the "(a11y)" part from the prefix. Some information on this here.
  • In the commit message, we use Closes: CXSPA-xxxx and link it to the ticket in JIRA.

@uroslates uroslates changed the title feat(a11y): add * to required billing address form fields on checkout pyament details fix: add * to required billing address form fields on checkout payment details Oct 16, 2024
@uroslates
Copy link
Contributor Author

uroslates commented Oct 16, 2024 •
edited
Loading

Closes https://jira.tools.sap/browse/CXSPA-8189

developpeurweb
developpeurweb previously approved these changes Oct 16, 2024
View reviewed changes
@developpeurweb
Copy link
Contributor

@uroslates LGTM, just one last adjustment please, this other PR #19327 adds an ARIA attribute to asterisks, can you please sync up with @StanislavSukhanov and update your asterisks to include those attributes as well.

@developpeurweb developpeurweb dismissed their stale review October 16, 2024 19:57

meant to request changes

@uroslates
Copy link
Contributor Author

@uroslates LGTM, just one last adjustment please, this other PR #19327 adds an ARIA attribute to asterisks, can you please sync up with @StanislavSukhanov and update your asterisks to include those attributes as well.

Applied the requested change - * are now not read by the Readers.

@uroslates uroslates marked this pull request as ready for review October 17, 2024 12:06
@github-actions GitHub Actions
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft October 17, 2024 12:20
@uroslates uroslates marked this pull request as ready for review October 17, 2024 12:35
@uroslates uroslates merged commit cdc23a2 into develop Oct 17, 2024
28 checks passed
@uroslates uroslates deleted the feature/CXSPA-8189 branch October 17, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developpeurweb developpeurweb developpeurweb approved these changes

@Zeyber Zeyber Zeyber left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@uroslates @Zeyber @developpeurweb @ulates-sap